Skip to content

fix(chart): Render global.daemonsetsTolerations into kai-config - #2076

Merged
gshaibi merged 2 commits into
kai-scheduler:mainfrom
dttung2905:wire-global-daemonsetTolerations
Aug 16, 2026
Merged

fix(chart): Render global.daemonsetsTolerations into kai-config#2076
gshaibi merged 2 commits into
kai-scheduler:mainfrom
dttung2905:wire-global-daemonsetTolerations

Conversation

@dttung2905

@dttung2905 dttung2905 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Description

In this piece of code

KAI-Scheduler/deployments/kai-scheduler/values.yaml

Lines 197 to 205 in cea080f

numaPlacementExporter:
image:
name: numa-placement-exporter
pullPolicy: IfNotPresent
# tag: "" # Optional: Override global.tag or Chart.AppVersion
# nodeSelector targets the DaemonSet at specific nodes (e.g. GPU/NUMA nodes). The global
# nodeSelector is intentionally NOT applied to this DaemonSet.
nodeSelector: {}
# tolerations let the DaemonSet run on tainted worker nodes (merged with global.daemonsetsTolerations).
, it refers to global.daemonsetsTolerations but it is not wirted into kai-config. This PR fixes that

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)
  • Added a changelog fragment via make changelog (or applied the skip-changelog label). Do not edit CHANGELOG.md directly — pending fragments are folded into it at release time.

Breaking Changes

Additional Notes

@dttung2905
Render global.daemonsetsTolerations into kai-config
a2e827e 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905
Add changelog
18db72e 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

Total coverage: 54.6% -> 54.6% (delta 0.00%)

gshaibi
gshaibi approved these changes Aug 16, 2026
View reviewed changes

@gshaibi gshaibi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@gshaibi
gshaibi added this pull request to the merge queue Aug 16, 2026
Merged via the queue into kai-scheduler:main with commit 38dd06f Aug 16, 2026
17 of 19 checks passed
@KaiPilotBot

KaiPilotBot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

📝 Changelog fragment recorded

Thanks! This PR added the changelog fragment(s) below. Pending fragments are folded into CHANGELOG.md at release time, so it was intentionally not modified by this PR — your entry will appear in the next release:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enoodle enoodle enoodle approved these changes
@gshaibi gshaibi gshaibi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dttung2905 @KaiPilotBot @enoodle @gshaibi